Attempt to fix snap build #12882
Merged
Attempt to fix snap build #12882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12882 +/- ##
==========================================
+ Coverage 34.29% 34.34% +0.05%
==========================================
Files 2934 2965 +31
Lines 90216 90533 +317
Branches 16943 16977 +34
==========================================
+ Hits 30937 31094 +157
- Misses 56815 56975 +160
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
mzieniukbw
approved these changes
Jan 16, 2025
quexten
added a commit
that referenced
this pull request
Jan 16, 2025
* Attempt to fix snap build * Move snap * Add debug logging * Fix move * Remove debug logs (cherry picked from commit ca420d7)
quexten
added a commit
that referenced
this pull request
Jan 16, 2025
* Attempt to fix snap build * Move snap * Add debug logging * Fix move * Remove debug logs (cherry picked from commit ca420d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17137
📔 Objective
Snapcraft requires special packing using the
snapcraftcli instead of directly creating the image. The latter works for local snap installations but not for snapcraft.This is a change to the
pack:linstep that was originally introduced in #12187.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes